Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to reload web_app immediately via param for definition #442

Closed
wants to merge 1 commit into from
Closed

allow to reload web_app immediately via param for definition #442

wants to merge 1 commit into from

Conversation

jklare
Copy link

@jklare jklare commented Sep 8, 2016

  • Sometimes it's needed to immediately reload a web_app/apache2 to
    continue the chef-run, since the webserver is lateron used. This patch
    allows to set the reload_speed for the web_app definition (apache2
    service) via the parameter :reload_speed. The default behaviour does not
    change.

* Sometimes it's needed to immediately relaod a web_app/apache2 to
continue the chef-run, since the webserver is lateron used. This patch
allows to set the reload_speed for the web_app definition (apache2
service) via the parameter :reload_speed. The default behaviour does not
change.
@@ -557,6 +557,8 @@ combine the template with enabling a site, see `web_app`.

* `name` - Name of the site.
* `enable` - Default true, which uses `a2ensite` to enable the site. If false, the site will be disabled with `a2dissite`.
* `reload_speed` - Defaults to `:delayed` and can be set to `:immediately` to

This comment was marked as outdated.

@jklare
Copy link
Author

jklare commented Sep 9, 2016

I totally agree with @punkle here, but i think the biggest issue is the fact that these are definitions. @svanzoest Are there any plans on refactoring these to resources? I would be happy to help with that.

@svanzoest
Copy link
Contributor

@jklare this is part of #414 and the apache2@customresources branch has the current implementation. I am looking for feedback and some testing on that branch. I'd love to get your perspective on #414

@jklare
Copy link
Author

jklare commented Sep 26, 2016

@svanzoest sounds great, i will look trough the changes in that branch and post my feedback in #414 (sry for responding so slowly, i was on holiday the last 2 weeks)

@jklare jklare closed this Sep 26, 2016
@jklare jklare deleted the add_reload_speed branch September 26, 2016 07:29
@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants